Not all rrd files are beeing updated

[passie]

If have some problems on some rrd files.
The files are not updated because of an error/bug

As far as i can see the problem is in lib/identifyMetric.pm at line 93.

output log centstorage.log

1218031463 - Error:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE `metric_id` = '980'' at line 1
1218031463 - Error:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE `metric_id` = '880'' at line 1
1218031464 - Error:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE `metric_id` = '1396'' at line 1

[passie]

Additional info:
INSERT INTO metrics (metric_id, index_id, metric_name, unit_name, warn, crit, hidden, min, max, locked) VALUES
(880, 307, 'size', 'B', 0, 0, '0', 0, 0, NULL);

[passie]

if i write the sql statement to the log file i'm getting the following
but there is no 15581218100659 id

UPDATE `metrics` SET `warn` = '64748912640', `crit` = '76889333760'  WHERE `metric_id` = 15581218100659

[jmathis]

did you update to RC1 ?

[passie]

I just installed RC2, and now i'm unable to export the hosts.cfg,services.cfg.
Also i'm seeing high metrid id's which are not configured on my server:

metric_id` = 8491218525132'
So it looks like the problem is still there.

[macaronyde]

Hi, I can confirm the problem (beta6 - RC2), got the same entry in my logfiles.
The problem should be the statement in line 93 of lib/identifyMetric.pm
My fix is to change line 80
from:
$str .= "warn = '".$warn."'" if ($warn);
to:
$str .= "warn = '".$warn."'" if ($warn ne "");

Regards Matthias

[jmathis]

ok commited r6187

now please test :)

thanks

[jmathis]

Ok I test, It's working fine.

Thanks.